Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tellstick] Add support for suggestion finder #16228

Merged
merged 3 commits into from
Jan 8, 2024
Merged

[tellstick] Add support for suggestion finder #16228

merged 3 commits into from
Jan 8, 2024
+15 −7

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Jan 7, 2024 •
edited by jlaur
Loading

Split from #16220

Signed-off-by: Andrew Fiddian-Green [email protected]

@andrewfg
[tellstick] split PR
a9a760b 
Signed-off-by: Andrew Fiddian-Green <[email protected]>
@andrewfg andrewfg added the enhancement An enhancement or new feature for an existing add-on label Jan 7, 2024
@andrewfg andrewfg self-assigned this Jan 7, 2024
@andrewfg andrewfg requested a review from a team as a code owner January 7, 2024 11:10
@andrewfg
Copy link
Contributor Author

andrewfg commented Jan 7, 2024

@jlaur 4yi

@andrewfg
[tellstick] regex shall ignore case
d989568 
Signed-off-by: Andrew Fiddian-Green <[email protected]>
@andrewfg
[tellstick] readme for new url
bc98aac 
Signed-off-by: Andrew Fiddian-Green <[email protected]>
@andrewfg
Copy link
Contributor Author

andrewfg commented Jan 8, 2024

@wborn I fixed the regex. And I also updated the readme according to #16220. => Probably the latter should be back-ported to v4.1.x ??

wborn
wborn approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit 71dbd78 into openhab:main Jan 8, 2024
3 checks passed
@wborn wborn added this to the 4.2 milestone Jan 8, 2024
@wborn
Copy link
Member

wborn commented Jan 8, 2024

Probably the latter should be back-ported to v4.1

IIRC the docs for final releases aren't updated automatically even if PRs are backported.

@andrewfg andrewfg mentioned this pull request Jan 12, 2024
Closed
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 27, 2024
@andrewfg @andrasU
[tellstick] Add support for suggestion finder (openhab#16228)
6e204b1 
Also updates the readme for the new URL.

Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Andras Uhrin <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@andrewfg @austvik
[tellstick] Add support for suggestion finder (openhab#16228)
ac56d88 
Also updates the readme for the new URL.

Signed-off-by: Andrew Fiddian-Green <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
@andrewfg andrewfg deleted the tellstick2 branch August 25, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees

@andrewfg andrewfg

Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewfg @wborn